From: Nicolas Pitre Date: Sun, 20 Aug 2006 23:10:23 GMT Subject: Re: Unresolved issues #3 Message-ID: In-Reply-To: <44E68DCD.8010603@gmail.com> On Fri, 18 Aug 2006, A Large Angry SCM wrote: > Nicolas Pitre wrote: > > On Fri, 18 Aug 2006, A Large Angry SCM wrote: > >> That doesn't prove the non-existence of other code to do it. > > > > So? If the official and primary code for GIT doesn't support it, what > > is the point? I'm telling you that if such packs exist they will simply > > barf with all official GIT releases later than v1.1.6 making your > > argument pointless. > > > > I don't mind you documenting that historic intent for a bit that was > > never officially used, but at least let's document it right. > > Historic fact. Between Thu May 19 08:56:22 2005 and Thu Feb 9 21:06:38 > 2006 bit 6 of the first byte of a delta hunk was interpreted to mean > that the source of the copy was the result buffer. From Thu May 19 > 08:56:22 2005 on, the code to decode delta hunks in type 2 packs was > available to everyone and anyone interested could make a pack encoder > that would create packs that the core Git code would correctly read. The > commit of Thu Feb 9 21:06:38 2006, d60fc, actually introduced a bug > that would treat valid type 2 packs as invalid. The "actually introduced a bug" sentence is your own interpretation not a _fact_. And I simply disagree with that interpretation of yours. I don't think this is worth arguing any further. Nicolas