From: Linus Torvalds Date: Wed, 12 Jul 2006 15:13:22 GMT Subject: Re: [PATCH 2/3] sha1_file: add the ability to parse objects in "pack file format" Message-ID: In-Reply-To: On Wed, 12 Jul 2006, Peter Baumann wrote: > > This doesn't match the logic used in unpack_object_header, which is used > in the packs: Yeah, good point. I reversed the meaning of the high bit by mistake. In pack-files, the high bit is a "there is more to come" bit, and in my new code it was a "this is the last byte" bit. It doesn't matter for the ultimate reason for this (being able to re-use the actual _bulk_ of the data), but having it be different would be stupid and confusing, and means that we can't later try to use the same routines for packing/unpacking the objects. Junio - do you want me to send an updated patch, or do you want to reverse bit#7 yourself? Linus