From: Linus Torvalds <torvalds@osdl.org>
Date: Wed, 24 May 2006 02:17:44 GMT
Subject: Re: [PATCH] Add a test-case for git-apply trying to add an ending line
Message-ID: <Pine.LNX.4.64.0605231916210.5623@g5.osdl.org>
In-Reply-To: <Pine.LNX.4.64.0605231905470.5623@g5.osdl.org>



On Tue, 23 May 2006, Linus Torvalds wrote:
>
> +	/*
> +	 * If we don't have any trailing data in the patch,
> +	 * we want to match the final ending '\0' byte in
> +	 * the file too..
> +	 */

Btw, ignore the comment. I was thinking of doing the matching differently 
(just make the source buffer include a '\0' at the end, and forcing that 
to match), but once I actually wrote it, it ended up being much easier to 
just check the offset/size difference.

So that "final ending '\0' byte in the file" part of the comment is just 
nonsense.

		Linus