From: Linus Torvalds <torvalds@osdl.org>
Date: Thu, 18 May 2006 17:22:03 GMT
Subject: Re: Do "git add" as a builtin
Message-ID: <Pine.LNX.4.64.0605181020570.10823@g5.osdl.org>
In-Reply-To: <7vzmhfnupz.fsf@assigned-by-dhcp.cox.net>



On Thu, 18 May 2006, Junio C Hamano wrote:
> 
> Perhaps, but unresolve splits an entry that is available from
> the heads being merged, so it would use unverified filename to
> try finding the ents from trees, but get_tree_entry() would not
> find one, so I think we are safe already.

Yes, I agree, that looks safe.

> I doubt this would break people's scripts.  If they were relying
> on the old behaviour, that means they threw real paths and
> garbage at update-index and relied on it to sift them apart,
> which indicates they were buggy to begin with anyway.

Agreed. I don't think the semantic change can really break anything, and 
if anything will probably help expose any really strange/broken stuff.

		Linus