From: Davide Libenzi <davidel@xmailserver.org>
Date: Sun, 02 Apr 2006 17:35:53 GMT
Subject: Re: [RFH] xdiff shows trivially redundant diff.
Message-ID: <Pine.LNX.4.64.0604021035130.30097@alien.or.mcafeemobile.com>
In-Reply-To: <7v4q1cmj7l.fsf@assigned-by-dhcp.cox.net>

On Sun, 2 Apr 2006, Junio C Hamano wrote:

> $ git diff-tree -p 52e8a6^2 52d8a6 -- git-fetch.sh
>
> shows a change that trivially is redundant, like this:
>
>    diff --git a/git-fetch.sh b/git-fetch.sh
>    index b4325d9..de4f011 100755
>    --- a/git-fetch.sh
>    +++ b/git-fetch.sh
>    @@ -320,7 +320,7 @@ fetch_main () {
>         ( : subshell because we muck with IFS
>           IFS="    $LF"
>           (
>    -         git-fetch-pack $exec $keep "$remo...
>    +         git-fetch-pack $exec $keep --thin...
>           ) |
>           while read sha1 remote_name
>           do
>    @@ -367,21 +367,26 @@ fetch_main "$reflist"
>
>     # automated tag following
>     case "$no_tags$tags" in
>    -'')
>    -       taglist=$(IFS=" " &&
>    -       git-ls-remote $upload_pack --tags "$remote" |
>    ...
>    -       done)
>    +'')
>    +       case "$reflist" in
>    +       *:refs/*)
>    ...
>
> Notice the first '-' and '+' lines of second hunk are identical?
>
> There is another interesting thing.  This is running diff
> between 52e8a6^2 and 52d8a6 blobs, but if I change them slightly
> so that the first hunk is not different, then this anomaly
> disappears.

Could you send me the two files that creates the above diff?


- Davide