From: Linus Torvalds <torvalds@osdl.org>
Date: Sun, 12 Feb 2006 06:53:16 GMT
Subject: Re: [PATCH] binary-tree-based objects.
Message-ID: <Pine.LNX.4.64.0602112237580.3691@g5.osdl.org>
In-Reply-To: <7vaccxdsaf.fsf@assigned-by-dhcp.cox.net>



On Sat, 11 Feb 2006, Junio C Hamano wrote:
> 
> It turns out that Johannes (with my patch to fix possible
> unsigned int alignment issue and the initial call to
> find_object()) is the clear winner.

Having looked at it, I will have to agree. Johannes' approach looks 
pretty clean, and has the same memory overhead mine has (two pointers per 
object in the hash - one used, one empty), but has a lot fewer memcmp() 
calls and pointer chasing.

So I'll growl softly but concur. Johannes' code isn't even very complex.

		Linus