From: Daniel Barkalow <barkalow@iabervon.org>
Date: Mon, 24 Oct 2005 06:28:04 GMT
Subject: Re: User-relative paths
Message-ID: <Pine.LNX.4.64.0510240219410.25300@iabervon.org>
In-Reply-To: <7voe5gypvi.fsf@assigned-by-dhcp.cox.net>

On Sun, 23 Oct 2005, Junio C Hamano wrote:

> Petr Baudis <pasky@suse.cz> writes:
> 
> >> diff --git a/Makefile b/Makefile
> >> index 903c57c..87188ea 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -359,6 +362,9 @@ git-cherry-pick: git-revert
> >>  %.o: %.S
> >>  	$(CC) -o $*.o -c $(ALL_CFLAGS) $<
> >>  
> >> +$(SERVERSIDE_PROGRAMS) : git-%$X : %.o srvside-ssh.o $(LIB_FILE)
> >> +	$(CC) $(ALL_CFLAGS) -o $@ $(filter %o,$^) $(LIBS)
> >> +
> >>  git-%$X: %.o $(LIB_FILE)
> >>  	$(CC) $(ALL_CFLAGS) -o $@ $(filter %.o,$^) $(LIBS)
> >>  
> >
> > Why are you adding own compilation command, and why is it inconsistent
> > with the git-%$X's one?
> 
> Although I'd prefer the simplicity of putting srvside-ssh.o in
> LIB_OBJS, this is arguably defensible; it avoids relinking of
> everything else merely because srvside-ssh.c is changed.

The line:

$(SERVERSIDE_PROGRAMS): srvside-ssh.o

would suffice for that.

	-Daniel
*This .sig left intentionally blank*