From: Daniel Barkalow <barkalow@iabervon.org>
Date: Thu, 20 Oct 2005 20:32:08 GMT
Subject: Re: [PATCH] Do not send "want" lines for complete objects
Message-ID: <Pine.LNX.4.64.0510201630000.25300@iabervon.org>
In-Reply-To: <Pine.LNX.4.63.0510200559540.3394@wbgn013.biozentrum.uni-wuerzburg.de>

On Thu, 20 Oct 2005, Johannes Schindelin wrote:

> Hi,
> 
> > > +		    ((o = parse_object(remote)) != NULL) &&
> > > +		    (o->flags & COMPLETE) &&
> 
> I just realized that parse_object() always reads the file, then does a 
> lookup (which makes the above code work), and then parses the file. It 
> always does all of these steps, even if the object was already parsed. Any 
> reason for this?

I'm lazy and haven't sent in a patch to clean that up. There's no reason 
it couldn't check whether the value it gets is already parsed.

	-Daniel
*This .sig left intentionally blank*