From: Linus Torvalds <torvalds@osdl.org>
Date: Tue, 18 Oct 2005 20:42:36 GMT
Subject: Re: [CORRECTED PATCH] git-fetch-pack: avoid unnecessary zero packing
Message-ID: <Pine.LNX.4.64.0510181339220.3369@g5.osdl.org>
In-Reply-To: <Pine.LNX.4.64.0510181333380.3369@g5.osdl.org>



On Tue, 18 Oct 2005, Linus Torvalds wrote:
> 
> I'll see if I can come up with a good patch.

I see you already did. Looks fine. I'd suggest limiting the commits by 
number in mark_recent_commit_complete(), because

 (a) somebody might have their clock set wrong and you don't want to walk 
     a huge tree just because of something like that.
 (b) you might just have imported a huge history (badly) from somewhere 
     else
 (c) a _lot_ can happen in five days with automated things.

but yes, the approach looks very sane otherwise.

		Linus