From: Linus Torvalds <torvalds@osdl.org>
Date: Mon, 17 Oct 2005 00:45:24 GMT
Subject: Re: Do you use "git-apply --show-files"?
Message-ID: <Pine.LNX.4.64.0510161740000.23590@g5.osdl.org>
In-Reply-To: <7vek6lxq1d.fsf@assigned-by-dhcp.cox.net>



On Sun, 16 Oct 2005, Junio C Hamano wrote:
>
> As a part of "funny pathname character" updates, I was reviewing
> "apply.c" and have two questions on its "--show-files" flag.
> 
>  * Unlike other informational flags like --stat and --summary,
>    it does not turn off "apply".  Is it intentional? 
> 
>  * Do you (or anybody else) use it, and if so how?

As far as I'm concerned, you can remove it.

The point of show-files was to have the index update be based on the files 
that were updated, it I was originally not planning to updating the index 
directly in git-apply, but instead do something like

	files=$(git-apply --show-files)
	git-update-cache --add --delete -- $files

but it turned out to be a lot easier to just update the index.

So just remove that flag, I doubt it has ever been used.

		Linus