From: Grzegorz Kulewski Date: Mon, 14 May 2007 01:07:30 GMT Subject: Re: [PATCH] Require JDK1.5 Message-ID: In-Reply-To: <11791001343234-git-send-email-robin.rosenberg@dewire.com> On Mon, 14 May 2007, Robin Rosenberg wrote: > This changes project settings to requre Java 5 and > also tightens some compiler settings. > > Signed-off-by: Robin Rosenberg > --- > .../.settings/org.eclipse.jdt.core.prefs | 22 ++++++++++--------- > .../.settings/org.eclipse.jdt.ui.prefs | 5 +-- > .../.settings/org.eclipse.jdt.core.prefs | 22 ++++++++++--------- > .../.settings/org.eclipse.jdt.ui.prefs | 5 +-- > .../.settings/org.eclipse.jdt.core.prefs | 22 ++++++++++--------- > .../.settings/org.eclipse.jdt.ui.prefs | 5 +-- > .../.settings/org.eclipse.jdt.core.prefs | 22 ++++++++++--------- > .../.settings/org.eclipse.jdt.ui.prefs | 3 +- > .../src/org/spearce/jgit/lib/ObjectIdMap.java | 4 +- > 9 files changed, 57 insertions(+), 53 deletions(-) [snip] > diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java > index c397a0d..63796fd 100644 > --- a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java > +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectIdMap.java > @@ -50,9 +50,9 @@ public class ObjectIdMap implements Map { > > public ObjectIdMap(Map sample) { > try { > - Method m=sample.getClass().getMethod("clone", null); > + Method m=sample.getClass().getMethod("clone", (Class[])null); > for (int i=0; i<256; ++i) { > - level0[i] = (Map)m.invoke(sample, null); > + level0[i] = (Map)m.invoke(sample, (Object[])null); > } > } catch (IllegalAccessException e) { > throw new IllegalArgumentException(e); I wonder why one would need changes like this? These casts are not needed for anything as far as I can see and your IDE should easily tell you what type that parameter is. No? Thanks, Grzegorz Kulewski