From: David Lang Date: Sun, 22 Apr 2007 20:27:49 GMT Subject: Re: [PATCH 4/4] Add 'filter' attribute and external filter driverdefinition. Message-ID: In-Reply-To: On Sun, 22 Apr 2007, Nicolas Pitre wrote: > On Sun, 22 Apr 2007, David Lang wrote: > >> On Sat, 21 Apr 2007, Junio C Hamano wrote: >> >>>> 3. why specify seperate clean/smudge programs instead of just one >>>> script with a read/write parameter? >>> >>> I think the most common two ways have clean as a cleaner and >>> smudge as a no-op (similar to crlf=input conversion), or clean >>> and smudge are inverse operations (similar to crlf=true >>> conversion. I do not see a sane case where clean and smudge are >>> the same, unless you are thinking about the toy demonstration >>> test piece I added to t0021 which uses rot13 as both clean and >>> smudge filters. >> >> actually, I'm thinking of much more complicated filters, where it's easier to >> have one program do both functions then it is to have two seperate programs >> (like tar -c /tar -x) > > Just specify the same program in both entries with the appropriate > parameter and be happy. > > It is much easier to have two entries with the same program than having > only one entry when you actually have two separate programs. agreed, this is why I said that this was a fairly minor thing. David Lang