From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 28 Feb 2007 15:10:51 GMT
Subject: Re: git-remote and remotes with '.' in their names
Message-ID: <Pine.LNX.4.63.0702281607220.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <45E597CF.9000009@lu.unisi.ch>

Hi,

On Wed, 28 Feb 2007, Paolo Bonzini wrote:

> Hello,
> 
> >  	for (@remotes) {
> > -		if (/^remote\.([^.]*)\.(\S*)\s+(.*)$/) {
> > +		if (/^remote\.(.*)\.(\S*)\s+(.*)$/) {
> 
> You probably want either
> 
> +		if (/^remote\.(\S*)\.(\S*)\s+(.*)$/) {
> 
> or
> 
> +		if (/^remote\.(\S*)\.([^.]*)\s+(.*)$/) {

Did you mean to prevent the remote starting with a dot? IMHO that would be 
a good change, but AFAIS both your proposals don't do that.

Ciao,
Dscho