From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 26 Feb 2007 18:55:18 GMT
Subject: Re: Syntax highlighting for gitweb
Message-ID: <Pine.LNX.4.63.0702261953420.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20070226181858.GC11232@hoeg.nl>

Hi,

On Mon, 26 Feb 2007, Ed Schouten wrote:

> I just wrote a really awful patch to add syntax highlighting to gitweb:
> 
> [...]
>
> +	$pid = open2(\*HLR, \*HLW, "highlight -f --syntax c");

Since this fork()s an external program, which is possibly expensive, or 
can fail because the program is not there, you should at least

- document it, and
- make it optional.

Ciao,
Dscho