From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 17 Feb 2007 17:50:51 GMT
Subject: Re: [PATCH] name-rev: introduce the --ref-filter=<regex> option
Message-ID: <Pine.LNX.4.63.0702171840140.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20070217145921.GA16747@coredump.intra.peff.net>

Hi,

On Sat, 17 Feb 2007, Jeff King wrote:

> On Sat, Feb 17, 2007 at 03:02:36PM +0100, Johannes Schindelin wrote:
> 
> > > Instead of (or, in addition to) --tags, to use only tags for naming,
> > > you can now use --ref-filter=<regex> to specify which refs are
> > > used for naming.
> > > 
> > > Example:
> > > 
> > > 	$ git name-rev --ref-filter='/v1' 33db5f4d
> > > 	33db5f4d tags/v1.0rc1^0~1593
> > 
> > Likes, dislikes?
> 
> It's a neat idea, but I wonder if you could make it even more flexible
> by simply accepting a list of possible refs, and then you could filter
> using grep, or your own more complex selection algorithm.

You can do that with regexps also. And you're right, my code was meant to 
be simple...

Ciao,
Dscho