From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 01 Feb 2007 23:26:35 GMT
Subject: Re: git repack -a -d is not safe
Message-ID: <Pine.LNX.4.63.0702020023170.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20070201205934.GA19057@spearce.org>

Hi,

On Thu, 1 Feb 2007, Shawn O. Pearce wrote:

> Matthias Lederhofer <matled@gmx.net> wrote:
> > First the object is unpacked, start something using read_sha1_file.
> > read_sha1_file: try packed object (fails)
> > run git repack -a -d
> > read_sha1_file: try to read the loose object (fails)
> > read_sha1_file: reread list of packs
> > run git repack -a -d so it will create a new pack
> > read_sha1_file: tries to open the old packs, not the new one, and
> >                 fails
> 
> My 4 patch series that I just posted should (partially) fix this
> problem.  We cannot close it completely however as there always
> exists the potential of the OS to starve the reader and allow 2
> full repacks between the time the reader notices a .idx file and
> the time the reader could open the .pack.

I may be misunderstanding the problem, but can't we just keep looking for 
a new pack until either there is _no_ new pack to be mapped, or the object 
is found?

Ciao,
Dscho