From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 01 Feb 2007 09:20:19 GMT
Subject: Re: [PATCH] Make gitk work reasonably well on Cygwin.
Message-ID: <Pine.LNX.4.63.0702011016430.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <45C14563.8060707@verizon.net>

Hi,

On Wed, 31 Jan 2007, Mark Levedahl wrote:

> 1) Regarding the size of the patch. I tried many different approaches to 
> getting the layout to work on Cgywin as well as Linux, ultimately the 
> only approach that worked required changing the very top level structure 
> containing the Tk widgets. As the style used names all widgets using 
> their parents, every widget's name is changed. This makes the patch seem 
> more complex than it is, many changes are just changing names.

Well, I don't like the size mainly because it makes it absolutely 
impossible for me to review it. After 20 lines of just renamed widget 
paths I really lose all my concentration.

And then I find that you also fixed whitespace breakage, which does not 
belong in this patch.

Ciao,
Dscho