From: Johannes Schindelin Date: Sat, 13 Jan 2007 11:19:47 GMT Subject: Re: [PATCH] Reencode committer info to utf-8 before formatting mail header Message-ID: In-Reply-To: <7vmz4nog5b.fsf@assigned-by-dhcp.cox.net> Hi, On Fri, 12 Jan 2007, Junio C Hamano wrote: > Side note. The previous patch does not help if your commit were > made in non UTF-8 with not too recent git; the code assumes that > commit messages without the new "encoding" headers are in UTF-8. Why not just use is_utf8() and warn, or error out, if the message is not UTF-8? (I tend towards the erroring out, since this _is_ a new feature, and gives undesired results with "old" commits.) Ciao, Dscho