From: Johannes Schindelin Date: Sat, 30 Dec 2006 19:24:01 GMT Subject: Re: [PATCH] git-fetch: Avoid reading packed refs over and over again Message-ID: In-Reply-To: <4596B837.8030108@xs4all.nl> Hi, On Sat, 30 Dec 2006, Han-Wen Nienhuys wrote: > Johannes Schindelin escreveu: > > > > Here you have to check first, if len > 3. Strictly speaking, there should > > not be any line coming in which is shorter than 42 bytes. But I was > > recentely bitten by such an assuption... > > > > Overall, I like it. I even have the impression that this could actually > > open a way to build in fetch instead of relying on a POSIX conformant and > > fast shell for such a central part of git. > > is there any chance of this going in GIT 1.5.0 ? It's not in the rc0 > release. Um. $ git grep -e exclude-existing v1.5.0-rc0 v1.5.0-rc0:builtin-show-ref.c: if (!strcmp(arg, "--exclude-existing")) v1.5.0-rc0:builtin-show-ref.c: if (!strncmp(arg, "--exclude-existing=", 19)) v1.5.0-rc0:git-fetch.sh: git-show-ref --exclude-existing=refs/tags/ | The last line means that it _is_ in v1.5.0-rc0. (BTW it is the commit tags/v1.5.0-rc0~84, which I found by "git log v1.5.0-rc0 git-fetch.sh | git name-rev --tags --stdin | less".) Ciao, Dscho