From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 23 Dec 2006 23:46:57 GMT
Subject: Re: warn non utf-8 commit log messages.
Message-ID: <Pine.LNX.4.63.0612240043510.19693@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vfyb6qth6.fsf_-_@assigned-by-dhcp.cox.net>

Hi,

On Sat, 23 Dec 2006, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >> But I had enough of UTF-8 for a day.
> >
> > Okay, so I lied (this are both patches revised and combined):
> 
> I am thinking of putting this in 'next', with the following
> changes on top of your combined patch.
> 
> git-commit-tree warns if the commit message does not minimally
> conform to the UTF-8 encoding when i18n.commitencoding is either
> unset, or set to "utf-8".  It does not die as in your version.

Yeah, this is nicer.

> -			if (w < width || space < 0) {
> +			if (w < width || !space) {

This is a real bug fix. Thank you. I changed quite a bit between offset 
and char*, and eventually forgot this part.

Ciao,
Dscho