From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 27 Nov 2006 23:33:24 GMT
Subject: Re: SEGV when lookup_* returns NULL
Message-ID: <Pine.LNX.4.63.0611280032300.30004@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vu00kftbq.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 27 Nov 2006, Junio C Hamano wrote:

> Martin Waitz <tali@admingilde.org> writes:
> 
> > All the lookup_{blob,tree,commit} functions check that the object
> > really is of the requested type and return NULL otherwise.
> > However this NULL pointer is not checked in the calling functions.
> >
> > Should we make lookup_* to just die when invoked on another object-type?
> 
> Making lookup_{specific type} die when they see unexpected type
> would not hurt that much, I think, aside from the possibility
> that some callers may check NULL to see if object already
> exists, but they should be using has_sha1_file() instead.

And it would totally clobber the long term goal of libifying git.

Ciao,
Dscho