From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 25 Nov 2006 18:49:32 GMT
Subject: Re: [PATCH 3/5] get_shallow_commits: Avoid memory leak if a commit has been reached already.
Message-ID: <Pine.LNX.4.63.0611251947310.30004@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <ek9u4f$vmk$1@sea.gmane.org>

Hi,

On Sat, 25 Nov 2006, Anand Kumria wrote:

> Any reason you didn't do:
> 
> if (!commit->util)
> 	commit->util = xcalloc(1, sizeof(int));

xmalloc() does not initialize the memory. Therefore, it is usually 
preferred if you initialize the memory yourself. In this case, the memory 
is initialized to 0, even if it is not allocated.

It may be a minor performance issue, but it is a good habit to use xcalloc 
only if it is needed.

Ciao,
Dscho