From: Johannes Schindelin Date: Thu, 02 Nov 2006 09:42:46 GMT Subject: Re: Problem with git-push Message-ID: In-Reply-To: <7v8xiu3ksl.fsf@assigned-by-dhcp.cox.net> Hi, On Wed, 1 Nov 2006, Junio C Hamano wrote: > - if (chmod(path, mode) < 0) > + if (mode != st.st_mode && chmod(path, mode) < 0) Oops. Somehow I missed this mail before replying. I'd like to point out that it's safer to check for (mode & st.st_mode != mode), since we should leave broader permissions as are. Ciao, Dscho