From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 20 Oct 2006 12:48:25 GMT
Subject: Re: VCS comparison table
Message-ID: <Pine.LNX.4.63.0610201444030.14200@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <200610201403.53664.jnareb@gmail.com>

Hi,

On Fri, 20 Oct 2006, Jakub Narebski wrote:

> > But it does not change a thing. Since v0.99~653, we do not have any 
> > collision check, even if compiled with COLLISION_CHECK.
> 
> So why it is left in Makefile? Does defining this change a thing
> or not (in which case this section should be removed)?

It does not. The relevant parts in the code read like this:

sha1_filc.c:1442
                /* FIXME!!! Collision check here ? */

sha1_file.c:1541
                /*
                 * FIXME!!! We might do collision checking here, but we'd
                 * need to uncompress the old file and check it. Later.
                 */

It was hoped that the people who actually care would implement that 
functionality. (Note that in an earlier version, the check was 
implemented, but would have to be different these days: pack files did not 
exist then).

Ciao,
Dscho