From: Johannes Schindelin Date: Thu, 12 Oct 2006 22:52:12 GMT Subject: Re: [PATCH 1/2] diff --stat: use asymptotic scaling in graph Message-ID: In-Reply-To: <452EC625.7050301@gmail.com> Hi, On Thu, 12 Oct 2006, A Large Angry SCM wrote: > Martin Waitz wrote: > > On Thu, Oct 12, 2006 at 03:20:09PM -0700, A Large Angry SCM wrote: > > > > + if (it) > > > > + return it * width / (it + width) + 1; > > > > + else > > > > + return 0; > > > No conditional needed: > > > > > > return it * width / (it + width - 1) > > > > But then it would start scaling much earlier > > (for width 10: at 2 instead of 4). > > This is not bad per se, but different... > > > > OK: > return (it * width + (it + width)/2)) / (it + width - 1) > > Now it's back at 4. ;-) Am I the only one finding non-linear diffstat ugly and misleading? Ciao, Dscho