From: Johannes Schindelin Date: Wed, 20 Sep 2006 21:31:36 GMT Subject: Re: [PATCH] sha1_name: accept output of git-describe Message-ID: In-Reply-To: <7v64figrhu.fsf@assigned-by-dhcp.cox.net> Hi, On Wed, 20 Sep 2006, Junio C Hamano wrote: > Shouldn't you also verify the leading ref (most likely a tag) > exists (and optionally check that it precedes the commit you > decoded into, but that is probably more expensive than it's > worth)? I debated this with myself. But there is the cost, and more importantly the possibility that your victim^H^H^H^H^H^Hother side does not have the tag at all (for whatever reasons). Ciao, Dscho