From: Johannes Schindelin Date: Wed, 23 Aug 2006 13:45:04 GMT Subject: Re: [PATCH] Fix a comparison bug in diff-delta.c Message-ID: In-Reply-To: <1156324675415-git-send-email-madcoder@debian.org> Hi, On Wed, 23 Aug 2006, Pierre Habouzit wrote: > - for (i = 4; (1 << i) < hsize && i < 31; i++); > + for (i = 4; (1u << i) < hsize && i < 31; i++); The variable i never takes on the value 31 (or any higher value), so there is no bug here. Unless you port git to a system where an int has less than 32 bit. Ciao, Dscho