From: David Rientjes <rientjes@google.com>
Date: Mon, 14 Aug 2006 22:51:01 GMT
Subject: Re: [PATCH 28/28] makes upload_pack void
Message-ID: <Pine.LNX.4.63.0608141549150.21515@chino.corp.google.com>
In-Reply-To: <dbfc82860608141545s3e75457eo4be1201395e24354@mail.gmail.com>

On Tue, 15 Aug 2006, Nikolai Weibull wrote:
> I don't know for sure, but I'm guessing the intention was to be able
> to return a failing code /if/ there ever was a condition where
> upload_pack() would fail, e.g., if send_ref() would return a status
> code instead of die():ing if it can't parse the given sha1.  In a
> future libification, the change of return type may have to be
> reverted.
> 

Of course.

If upload_pack were modified to return an error code based on a specific code 
path, I trust the implementer would know how to change void to int.

		David