From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 26 Jul 2006 19:57:18 GMT
Subject: Re: [PATCH 4/5] git-instaweb: Fall back to Apache when LigHTTP was not found
Message-ID: <Pine.LNX.4.63.0607262153380.29667@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vr708qih4.fsf@assigned-by-dhcp.cox.net>

Hi,

On Wed, 26 Jul 2006, Junio C Hamano wrote:

> Please don't use "which" in scripts.  Consult this thread:
> 
> http://thread.gmane.org/gmane.comp.version-control.git/23382/focus=23394

I remembered vaguely, so I searched in git-instaweb:

$ git grep -n which next:git-instaweb.sh
next:git-instaweb.sh:40: [white space...] which $httpd_only >/dev/null

Well, the fallback mechanism might not be that useful anyway: if you have 
apache, you have to specify the modules path. I'll do a patch instead 
which exits cleanly if either $httpd or $browser could not be executed, 
okay?

Ciao,
Dscho