From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 05 Jul 2006 07:57:57 GMT
Subject: Re: Experimental "git prune"
Message-ID: <Pine.LNX.4.63.0607050956240.29667@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.64.0607041539550.12404@g5.osdl.org>

Hi,

On Tue, 4 Jul 2006, Linus Torvalds wrote:

> static void process_tag(struct tag *tag, struct object_array *p, const char *name)
> {
> 	struct object *obj = &tag->object;
> 	struct name_path me;

AFAICS this variable is set, but not used:

> 
> 	if (obj->flags & SEEN)
> 		return;
> 	obj->flags |= SEEN;
> 
> 	me.up = NULL;
> 	me.elem = "tag:/";
> 	me.elem_len = 5;
> 
> 	if (parse_tag(tag) < 0)
> 		die("bad tag object %s", sha1_to_hex(obj->sha1));
> 	add_object(tag->tagged, p, NULL, name);
> }

As for the rest, I like it.

Ciao,
Dscho