From: Johannes Schindelin Date: Tue, 04 Jul 2006 14:18:49 GMT Subject: Re: [PATCH 1/3] Add read_cache_from() and discard_cache() Message-ID: In-Reply-To: <7virmepfhx.fsf@assigned-by-dhcp.cox.net> Hi, On Mon, 3 Jul 2006, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Okay. After reading the comment, I am quite certain we can just set the > > index_file_timestamp to 0. > > Thanks. > > > So, I still think that these two lines should be in the cleanup part of > > get_merge_bases(). > > I think that is sane -- please make it so. Ummm. After reading my original mail again: bad tobacco that was. Of course, I meant discard_cache(), not get_merge_bases(). Setting index_file_timestamp in get_merge_bases() would be wrong. Sorry for the noise, Dscho