From: Johannes Schindelin Date: Mon, 03 Jul 2006 21:29:46 GMT Subject: Re: [PATCH] Make git-fmt-merge-msg a builtin Message-ID: In-Reply-To: <20060703191635.21ba0af3.tihirvon@gmail.com> Hi, On Mon, 3 Jul 2006, Timo Hirvonen wrote: > Seems that C89 requires free(NULL) to be a no-op but on some old systems > (SunOS) it may crash. IMNSHO these systems were designed to crash valid > programs and torture developers. At least it is not Malbolge. Or even VAX. (In that order.) > There are probably many free(NULL) and realloc(NULL, ...) uses in the > git source code and are not worth fixing. AFAIK realloc(NULL, ...) was fine even with K&R, whereas free(NULL) poses problems. Anyway, I do not _want_ to say that NULL should be free()d, because it just sounds wrong. Ciao, Dscho