From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 23 Jun 2006 22:28:41 GMT
Subject: Re: [PATCH 0/5] Rework diff options
Message-ID: <Pine.LNX.4.63.0606240024460.29667@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20060624011538.9bb179e7.tihirvon@gmail.com>

Hi,

On Sat, 24 Jun 2006, Timo Hirvonen wrote:

> This patch series cleans up diff output format options.

Very good.

Although I understand that to convert all users to the new convention, it 
is sensible to rename the constants, I think it is not good to change 
something as DIFF_FORMAT_RAW to OUTPUT_FMT_RAW in the resulting patch.

IMHO it is an unnecessary change, and accounts for a lot of the diffstat.

Ciao,
Dscho