From: Johannes Schindelin Date: Tue, 10 Jan 2006 21:03:22 GMT Subject: Re: [PATCH 2/2] Remember and use GIT_EXEC_PATH on exec()'s Message-ID: In-Reply-To: <1136925066.11717.605.camel@brick.watson.ibm.com> Hi, On Tue, 10 Jan 2006, Michal Ostrowski wrote: > On Tue, 2006-01-10 at 20:55 +0100, Johannes Schindelin wrote: > > Hi, > > > > On Tue, 10 Jan 2006, Junio C Hamano wrote: > > > > > Michal Ostrowski writes: > > > > > > > git programs exec other git programs, but they also exec non-git > > > > programs. I think it is not appropriate to change PATH (via > > > > prepend_to_path) because this may result in unexpected behavior when > > > > exec'ing non-git programs: > > > > > > This is a valid concern. > > > > Why? If what is prepended to PATH only contains git programs? > > > > > If git is installed with prefix=/usr, then that won't be the case. Okay, so here we have the problem: Two completely different setups. One into a standard location on the PATH (which used to be the default), the other with a libexec/ directory (which some want in the future). And a git wrapper which makes no difference between both. Wouldn't it make much more sense to have a switch in the Makefile, which says *if* we have a libexec/ directory? This switch would decide if we ever prepend the path with the libexec/ directory or not. Ciao, Dscho