From: Johannes Schindelin Date: Fri, 25 Nov 2005 11:05:54 GMT Subject: Re: git-send-mail in sh Message-ID: In-Reply-To: <4386DD45.6030308@op5.se> Hi, On Fri, 25 Nov 2005, Andreas Ericsson wrote: > It's worse than the perl version because; > 1. It doesn't thread the patch-series (which I personally prefer anyway since > it's easier to follow a thread on a particular patch that way). I think you can do that easily by providing a Message-ID: and a References: header. The id could be made up by "git-$commit_id" to be reasonably unique. > 2. The patches sent within the same second arrive in random order. I have that all the time. Sometimes, I send emails to the git list several minutes apart, and they come out in the wrong order. So it is no problem. > Sorry about the attachment btw. Thunderbird seems to wrap lines no > matter what I tell it. The hints in SubmittingPatches did not help? > Thoughts? Comments? I find it very cool. And easy to read. Just a few nits: You could use git-sh-setup.sh to ensure that you're in a valid git repository. Also, you could reuse the "die" function contained therein instead of a new function, "abort". Ciao, Dscho