From: Johannes Schindelin Date: Sat, 22 Oct 2005 00:35:42 GMT Subject: Re: [PATCH] Do not call git-rev-list from git-fetch-pack Message-ID: In-Reply-To: <7vbr1iv9nz.fsf@assigned-by-dhcp.cox.net> Hi, On Fri, 21 Oct 2005, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Yes. This makes it more simple, and is very efficient in the common case. > > How about increasing MAX_HAS to 64? > > The other day I saw HPA tried to sneak in a change to increase > it to 64, mingled with other changes. I think increasing it > makes sense. Agree. However, I do not see a way for upload-pack to force fetch-pack to send "have" lines. Maybe this would be an important change to the protocol? I imagine that I could craft a custom fetch-pack which DoS'es any current upload-pack. > Now the question is, if we count MAX_HAS on the fetch-pack side, > how would we coordinate that value with the real limit the other > end uses. I guess that would not matter too much. It would not > affect the correctness anyway. Really, there should be a way for upload-pack to say that enough is enough, and it wants to send the pack now. Ciao, Dscho