From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 08 Oct 2005 18:27:06 GMT
Subject: Re: First cut at git port to Cygwin
Message-ID: <Pine.LNX.4.63.0510082023130.25971@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.64.0510080900510.31407@g5.osdl.org>

Hi,

On Sat, 8 Oct 2005, Linus Torvalds wrote:

> I really think that you should just get rid of the mmap.
> 
> As it is, you're just slowing the code down on sane architectures. That's 
> not good.
> 
> So I'd suggest something like this instead.
> 
> Totally untested, of course.

Am I missing something? I don't see where the changes are written back to 
the fd. After all, mmap() is called with PROT_WRITE...

*shameless plug* Of course, this problem does not come up with my NO_MMAP 
patch.

Ciao,
Dscho