From: Nicolas Pitre <nico@cam.org>
Date: Wed, 01 Jun 2005 14:39:25 GMT
Subject: Re: [PATCH] Add -d flag to git-pull-* family.
Message-ID: <Pine.LNX.4.63.0506011032570.7439@localhost.localdomain>
In-Reply-To: <7vu0kilc21.fsf_-_@assigned-by-dhcp.cox.net>

On Wed, 1 Jun 2005, Junio C Hamano wrote:

> When a remote repository is deltified, we need to get the
> objects that a deltified object we want to obtain is based upon.
> Since checking representation type of all objects we retreive
> from remote side may be costly, this is made into a separate
> option -d; -a implies it for convenience and safety.

I wonder if making this optional makes sense.  In fact, if you believe 
having the option is useful then it should probably be the other 
way around i.e. to _not_ look at deltas when it is specified.  Otherwise 
you'll end up with an incoherent repository.

To minimize the cost a lot it could be possible to uncompress just the 
first 40 bytes or so which is enough to determine if the object is a 
delta and if so what object it is against.

What do you think?


Nicolas