From: Linus Torvalds Date: Tue, 30 Aug 2005 02:00:00 GMT Subject: Re: [PATCH 1/9] Fix git patch header processing in git-apply. Message-ID: In-Reply-To: <7vbr3g5hsb.fsf@assigned-by-dhcp.cox.net> On Mon, 29 Aug 2005, Junio C Hamano wrote: > > The code is simple enough and I see some beauty in it, but I > honor your veto, at least for now. Well, I didn't actually veto it when I saw the feature the first time, because I think it's a valid thing to do when applying patches by hand. It was only when I realized that Robert was trying to use it to import from somewhere else that it became broken. An import should use the most anal patches possible. Actually, an import should preferably never use patches at all, since that never really works for binary data. This is why the CVS importer actually checks out full files and imports them that way. The patch-based ones will fundamentally always have problems. Linus