From: Linus Torvalds Date: Wed, 24 Aug 2005 02:17:37 GMT Subject: Fix git-rev-parse breakage Message-ID: The --flags cleanup caused problems: we used to depend on the fact that "revs_only" magically suppressed flags, adn that assumption was broken by the recent fixes. It wasn't a good assumption in the first place, so instead of re-introducing it, let's just get rid of it. This makes "--revs-only" imply "--no-flags". [ Side note: we might want to get rid of these confusing two-way flags, where some flags say "only print xxx", and others say "don't print yyy". We'd be better off with just three flags that say "print zzz", where zzz is one of "flags, revs, norevs" ] Signed-off-by: Linus Torvalds --- diff --git a/rev-parse.c b/rev-parse.c --- a/rev-parse.c +++ b/rev-parse.c @@ -160,6 +160,7 @@ int main(int argc, char **argv) } if (!strcmp(arg, "--revs-only")) { revs_only = 1; + no_flags = 1; continue; } if (!strcmp(arg, "--no-revs")) {