From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 29 Jul 2005 10:23:27 GMT
Subject: Re: [PATCH] support older versions of libcurl
Message-ID: <Pine.LNX.4.58.0507291220350.5849@wgmdd8.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vll3qqrhu.fsf@assigned-by-dhcp.cox.net>

Hi,

On Thu, 28 Jul 2005, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > Some newer features of libcurl are used which are not strictly necessary
> > for http-pull. Use them only if libcurl is new enough to know about them.
>
> Do you need to check against that many versions?  Especially
> cleanup and init not depending on the same version number looks
> really suspicious.

I investigated the issue using curl's CVS. The different version numbers
are easily explained: While curl_global_init is defined starting from
0x070704, CURL_GLOBAL_ALL is only defined starting from 0x070800.

> Assuming that the answer is still yes, how about doing things
> this way instead?

Looks better.

Ciao,
Dscho