From: Linus Torvalds <torvalds@osdl.org>
Date: Thu, 07 Jul 2005 23:58:13 GMT
Subject: Re: [PATCH] rev-list: add "--objects=self-sufficient" flag.
Message-ID: <Pine.LNX.4.58.0507071657140.25104@g5.osdl.org>
In-Reply-To: <7vfyuqfa6r.fsf_-_@assigned-by-dhcp.cox.net>



On Thu, 7 Jul 2005, Junio C Hamano wrote:
>
> -		if (!strcmp(arg, "--objects")) {
> +		if (!strncmp(arg, "--objects", 9)) {
> +			if (!strcmp(arg+9, "=self-sufficient"))
> +				objects_self_sufficient = 1;

This is nasty - if you mis-spell "self-sufficient" (easy enough to do) 
you'll never know the end result isn't what you expected. It won't warn 
you in any way, it will just make a non-self-sufficient pack..

		Linus