From: Linus Torvalds Date: Sat, 25 Jun 2005 00:57:24 GMT Subject: Re: [PATCH 2/2] Fix oversimplified optimization for add_cache_entry(). Message-ID: In-Reply-To: <7vvf439vdl.fsf@assigned-by-dhcp.cox.net> On Fri, 24 Jun 2005, Junio C Hamano wrote: > > Resurrect the unoptimized directory-file conflict check code for > now as well. The new one did not handle higher stages properly. I really don't want to do this. Can you fix the "optimized" one instead? Currently the only "optimization" is really to just not call it for any non-stage0 thing, the real advantage is that the old code was totally unreadable and did everything in one big thing. I'm ok with dropping the optimization, but I don't want to lose the cleanup of splitting that horrible old function into two. Linus