From: Linus Torvalds <torvalds@osdl.org>
Date: Sun, 29 May 2005 18:31:05 GMT
Subject: Re: [PATCH] Adjust diff-helper to diff-tree -v -z changes.
Message-ID: <Pine.LNX.4.58.0505291129520.10545@ppc970.osdl.org>
In-Reply-To: <7vvf54xael.fsf_-_@assigned-by-dhcp.cox.net>



On Fri, 27 May 2005, Junio C Hamano wrote:
>
> The latest change to diff-tree -z output adds an extra line
> termination after non diff-raw material (the header and the
> commit message).  To compensate for this change, stop adding the
> output termination of our own.  "diff-tree -v -z" piped to
> "diff-helper -z" would give different result from "diff-tree -v"
> piped to "diff-helper" without this change.

I think this is really a bug in your "read_line()" interface.

You should include the terminating character in the line count.

This also fixes and simplifies "EOF" handling.

		Linus