From: Linus Torvalds Date: Sun, 01 May 2005 01:09:53 GMT Subject: Re: [PATCH] Resurrect diff-tree-helper -R Message-ID: In-Reply-To: <7v7jij3htp.fsf@assigned-by-dhcp.cox.net> On Sat, 30 Apr 2005, Junio C Hamano wrote: > > Diff-tree-helper take two patch inadvertently dropped the > support of -R option Talking about the diffs, I'm beginning to hate those "mode" things. Not only do they screw up diffstat (big deal), but they are pointless, since 99.9% of the time the mode stays the same. So it would be much nicer (I think) if mode changes are handled separately, with a simple separate line before the diff saying "Mode change: %o->%o %s", oldmode, newmode, path and not mess up the diff header. That way, you only see it when it actually makes any difference, and it's more readable both for humans _and_ machines as a result. Normal "patch" will just ignore the extra lines before the diff anyway, so it won't matter there. Comments? Linus