From: Linus Torvalds Date: Wed, 20 Apr 2005 16:33:27 GMT Subject: Re: [PATCH] write-tree performance problems Message-ID: In-Reply-To: On Wed, 20 Apr 2005, Linus Torvalds wrote: > > To actually go faster, it _should_ need this patch. Untested. See if it > works.. NO! Don't see if this works. For the "sha1 file already exists" file, it forgot to return the SHA1 value in "returnsha1", and would thus corrupt the trees it wrote. So don't apply, don't test. You won't corrupt your archive (you'll just write bogus tree objects), but if you commit the bogus trees you're going to be in a world of hurt and will have to undo everything you did. It's a good test for "fsck" though. It core-dumps because it tries to add references to NULL objects. Linus