From: Daniel Barkalow <barkalow@iabervon.org>
Date: Thu, 28 Apr 2005 05:49:07 GMT
Subject: Re: [1/5] Consider a blob to be parsed
Message-ID: <Pine.LNX.4.21.0504280131400.30848-100000@iabervon.org>
In-Reply-To: <Pine.LNX.4.58.0504272217240.18901@ppc970.osdl.org>

On Wed, 27 Apr 2005, Linus Torvalds wrote:

> 
> 
> On Thu, 28 Apr 2005, Daniel Barkalow wrote:
> >
> > We don't parse blobs at all, so any that we've got are as parsed as
> > they're going to get. Don't make fsck-cache mark them.
> 
> NO NO NO!
> 
> This is WRONG, dammit. I fixed it once, you are re-introducing the same
> bug.


> Daniel, the problem is that you parse them only when you SEE them, and 
> that is totally different from having seen a REFERENCE to them. One says 
> "I've seen this object", the other says "I _want_ to see this object". 
> They are two totally different things.

Good point; the right fix is actually to have a parse_blob that checks to
make sure it's there, and not have a special case for the simple case.

Replacement [1/5] to follow...

	-Daniel
*This .sig left intentionally blank*