From: Henrik Grubbström <grubba@roxen.com>
Date: Wed, 03 Mar 2010 10:40:00 GMT
Subject: Re: [PATCH 1/4] convert: Safer handling of $Id$ contraction.
Message-ID: <Pine.GSO.4.63.1003031129340.1164@shipon.roxen.com>
In-Reply-To: <7vljeamcpq.fsf@alter.siamese.dyndns.org>

On Tue, 2 Mar 2010, Junio C Hamano wrote:

> Henrik Grubbström <grubba@grubba.org> writes:
>
>> From: Henrik Grubbström (Grubba) <grubba@grubba.org>
>
> You can omit this line, as it is the same as your From: header.

I blame git-send-email(1).

>> The code to contract $Id:xxxxx$ strings could eat an arbitrary amount
>> of source text if the terminating $ was lost. It now refuses to
>> contract $Id:xxxxx$ strings spanning multiple lines.
>
> Hmm, at least when going from working tree to the index, shouldn't the
> code refuse _and_ die(), instead of silently pass the garbage through?

It depends; it could be part of some code that scans for the $Id: tag.
A warning might be appropriate though.

--
Henrik Grubbström					grubba@grubba.org
Roxen Internet Software AB				grubba@roxen.com