From: Jonathan Nieder <jrnieder@uchicago.edu>
Date: Mon, 30 Jun 2008 02:39:37 GMT
Subject: Re: [RFC/PATCH] Documentation: Don't assume git-sh-setup and git-parse-remote are in the PATH
Message-ID: <Pine.GSO.4.62.0806292131390.28041@harper.uchicago.edu>
In-Reply-To: <7vbq1kawje.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

> jrnieder@uchicago.edu writes:
>
>> [patch to use . "$(git --exec-path)/git-{parse-remote,sh-setup}"
>> instead of assuming they are in PATH]
>>
>> Junio: I stole the commit message from you. I hope you don't mind.
> 
> I don't, but reading the script again, I suspect it is not clear enough
> that the user is also responsible for setting up GIT_DIR appropriately
> before using it, perhaps by sourcing git-sh-setup.  We probably would want
> to add it in a separate patch.

Doesn't git-parse-remote.sh begin

	GIT_DIR=$(git rev-parse --git-dir 2>/dev/null) || :;

? And I don't imagine we want people to source git-sh-setup before
sourcing git-sh-setup...

Confused,
Jonathan