From: Aditya Garg Date: Tue, 06 May 2025 09:35:05 GMT Subject: Re: [PATCH v3 1/3] send-mail: improve checks for valid_fqdn Message-ID: In-Reply-To: > On 6 May 2025, at 11:08 AM, Aditya Garg wrote: > >  > >> On 6 May 2025, at 5:19 AM, Junio C Hamano wrote: >> >> Aditya Garg writes: >> >>> Due to current implementation, I was not able to send emails from >>> Ubuntu. >> >> It may be that send-email did not complain, but I have a suspicion >> that it the above is only half truth. We do have an ugly last-ditch >> fallback to claim that we are localhost.localdomain, instead of >> using a misconfigured maildomain name that servers would not like, >> but that name is a meaningless name; from the point of view of the >> server, if everybody uses that name, the name loses the meaning as >> an identifier. >> >> It is more like due to misconfiguration you couldn't send e-mails, >> and by tightening the condition to tell an invalid maildomain name >> and have the misconfigured maildomain name that is invalid replaced >> with "localhost.localdomain" fallback, you managed to send things >> out. >> >> The real fix for individual users may probably be to see how >> maildomain_net() and/or maildomain_mta() gives you a bogus >> "Macbook.." and fix _that_. Until that gets fixed, trying to use >> "localhost.localdomain" fallback might be a good workaround, but >> that is a workaround, not a real solution, isn't it? > > I think I should dig deeper on how the domain name is being assigned. > > Maybe its time to fix another perl module after Authen::SASL? I've noticed bug reports regarding this in Net::Domain perl library. Most reports seem to be not addressed. Maybe its no longer maintained? I think we can add a minimal check to ensure that there are no two dots together. Does that sound fair?